…ications

- Add spec/system/popup_notifications_screenshots_spec.rb: 15 screenshots
  across both surfaces — the account-page preference control (default off,
  dropdown open, set on, set off), the admin master switch, the control
  hidden when the master is off, a toast per notification type (reply,
  mention, quote, PM, like), content-shape variety (long title ellipsis,
  long message clamp, bell-icon fallback), and the off state (no toast).
  Toast shots publish crafted notifications on /notification/:id for exact,
  fast visual states; the real end-to-end path stays covered by the
  behavioral spec.
- Drop redundant `type: :system` metadata (Discourse/NoSystemSpecMetadata).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Js4yBxioTgsB8TkTd6HE9j

The On/Off dropdown was mounted on the `user-custom-preferences` outlet,
which lives on the PROFILE page — not the account page — so it never
rendered (the 01–04 screenshot example failed on a missing selector).

Move it to `user-preferences-account` (confirmed present on the account
page in Discourse 2026.7) and save immediately on change via
PUT /u/:username.json instead of relying on the account form's Save
button, which does not persist arbitrary custom fields. The value is
mirrored onto the current user for live toast gating and reverted on
error. This save path is the one exercised by
spec/requests/popup_notifications_pref_spec.rb.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Js4yBxioTgsB8TkTd6HE9j

The account-page dropdown rendered "[en.jtech_popup_notifications.preference.on]"
instead of "On" — YAML parses bare `on:`/`off:` keys as booleans, so those
two i18n keys never existed (title/instructions resolved fine). Quote the
keys. Caught by the 01 screenshot.

Also switch the screenshot spec's row selection to literal "On"/"Off"
instead of I18n.t, which is simpler and avoids the same trap.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Js4yBxioTgsB8TkTd6HE9j

- Heading line is now "Name — Action" (e.g. "pat — Liked your post"),
  driven by a per-type action label (config/locales client action.*).
- Add a small type-icon badge on the avatar's corner; postless
  notifications render the type icon on its own instead of an avatar.
- Decode the plugin's own `custom` notifications so they pop too and read
  correctly: moderator whispers (eye), flag notes (flag), and
  queued/pending-post approvals/rejections (check / xmark), plus the other
  mod-note kinds. These already publish on /notification/:id
  (staff_notifier + the whisper dedupe job), so the toast picks them up.
- Register the badge SVG icons.
- Screenshots: type shots now show the heading + badge; add whisper, flag,
  and pending-approved shots (16–18). Behavioral spec asserts the new
  name/action classes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Js4yBxioTgsB8TkTd6HE9j

The behavioral spec relied on PostCreator triggering a synchronous
`replied` notification, but PostAlerter runs async in system tests — so no
notification fired and the toast never appeared. The screenshot spec pushed
several notifications per example; under the parallel runner only the first
per page delivered.

Both now use the reliable pattern: one crafted MessageBus publish on
/notification/:id per FRESH page load (the same delivery core uses). The
client registers its subscription position at page load, before the publish,
so the message is always delivered. Behavioral spec proves off→no toast,
on→toast (name/action/title) + click-to-route + click-outside dismiss;
screenshot gallery grows to 18 (adds whisper/flag/pending).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Js4yBxioTgsB8TkTd6HE9j

After a warm page load, #post_1 can render before the browser's MessageBus
poll re-establishes its subscription, so a lone publish lands before the
client is listening and is missed — which dropped the 2nd+ shot in each
multi-shot example under turbo. Re-publish (fresh id) until the toast (or a
specific type icon) appears, in both the screenshot and behavioral specs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Js4yBxioTgsB8TkTd6HE9j

Two fixes for the failing system_tests job:

- The `liked` click-through failed on every batch because its target title
  "Target 1 liked" is 14 chars, under Discourse's 15-char minimum, so the
  topic fabrication raised. Give the target topics longer titles.

- The 55 browser-based gallery examples (18 single + 25 stacking + 30
  click-through) overloaded the shared, parallel system_tests job and timed
  out. Gate all three gallery specs behind JTECH_SCREENSHOT_GALLERY (set only
  in the Feature Screenshots workflow) so they generate screenshots there and
  skip in system_tests. Core behavior — off/on, click-to-open, dismiss —
  stays gated by the lean popup_notifications_spec.rb.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Js4yBxioTgsB8TkTd6HE9j

The stacking screenshots run only in the single-process Feature Screenshots
workflow (no per-example retry), where one flaky capture aborted the rest of
a grouped example and dropped later shots. Split the 25 stacks into 25
independent examples (fresh session each) so a flake isolates to one shot and
the gallery captures the rest.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Js4yBxioTgsB8TkTd6HE9j